walterddr commented on code in PR #12144:
URL: https://github.com/apache/pinot/pull/12144#discussion_r1424670078
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -46,11 +50,7 @@ private FunctionRegistry() {
private static final Logger LOGGER =
LoggerFactory.getLogger(FunctionRegistry.class);
- // TODO: consolidate the following 2
- // This FUNCTION_INFO_MAP is used by Pinot server to look up function by #
of arguments
- private static final Map<String, Map<Integer, FunctionInfo>>
FUNCTION_INFO_MAP = new HashMap<>();
Review Comment:
in order to delete this we need to stop supporting random `_` added inside
function name b/c `canonicalize(functionName)` will remove it.
we can keep this but mark as deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
