KKcorps opened a new pull request, #12169: URL: https://github.com/apache/pinot/pull/12169
We made change in the Table deletion flow to not remove segments from the upsert metadata manager and directly close it to save time. However, due to this change, we run into a metric mismatch issue, where the primary key count still shows up as the last updated one instead of 0 or NULL in dashboards. The fix is to set this metric to 0 explicitly when the metadata manager is closed. This can be verified in the following way: 1. Run UpsertQuickstart with the following VM options `-ea -javaagent:jmx_prometheus_javaagent-0.19.0.jar=9021:$PINOT_GIT_DIR/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml` 2. Run jconsole and connect to quickstart VM 3. Check the metric `"org.apache.pinot.common.metrics":type="ServerMetrics",name="pinot.server.upsertPrimaryKeysCount.upsertMeetupRsvp_REALTIME.0"` 4. Delete the table and check the metric again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
