saurabhd336 commented on code in PR #12208:
URL: https://github.com/apache/pinot/pull/12208#discussion_r1439339946
##########
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/data/writer/CsvWriter.java:
##########
@@ -38,6 +42,24 @@ protected String generateRow(DataGenerator generator) {
return StringUtils.join(values, ",");
}
+ @Override
+ public void write()
+ throws Exception {
+ super.write();
Review Comment:
IIUC, this go over the entire file twice? And repeats this for each file?
Could we avoid this by having the base FileWriter have a `init(FileWriter
writer)` function that can be called in the original write loop each time a
file is created, and the CSVWriter can override it to add the headers to avoid
the 2nd pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
