zhtaoxiang commented on code in PR #12073:
URL: https://github.com/apache/pinot/pull/12073#discussion_r1440714361
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml:
##########
@@ -31,14 +31,14 @@ rules:
tableType: "$2"
topic: "$3"
partition: "$4"
-- pattern: "\"org.apache.pinot.common.metrics\"<type=\"ServerMetrics\",
name=\"pinot.server.highestStreamOffsetConsumed.([^\\.]*?)_(OFFLINE|REALTIME)\\-(.+)\\-(\\w+)\"><>(\\w+)"
- name: "pinot_server_highestStreamOffsetConsumed_$5"
- cache: true
- labels:
- table: "$1"
- tableType: "$2"
- topic: "$3"
- partition: "$4"
+#- pattern: "\"org.apache.pinot.common.metrics\"<type=\"ServerMetrics\",
name=\"pinot.server.highestStreamOffsetConsumed.([^\\.]*?)_(OFFLINE|REALTIME)\\-(.+)\\-(\\w+)\"><>(\\w+)"
+# name: "pinot_server_highestStreamOffsetConsumed_$5"
+# cache: true
+# labels:
+# table: "$1"
+# tableType: "$2"
+# topic: "$3"
+# partition: "$4"
Review Comment:
+1
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml:
##########
@@ -31,14 +31,14 @@ rules:
tableType: "$2"
topic: "$3"
partition: "$4"
-- pattern: "\"org.apache.pinot.common.metrics\"<type=\"ServerMetrics\",
name=\"pinot.server.highestStreamOffsetConsumed.([^\\.]*?)_(OFFLINE|REALTIME)\\-(.+)\\-(\\w+)\"><>(\\w+)"
- name: "pinot_server_highestStreamOffsetConsumed_$5"
- cache: true
- labels:
- table: "$1"
- tableType: "$2"
- topic: "$3"
- partition: "$4"
+#- pattern: "\"org.apache.pinot.common.metrics\"<type=\"ServerMetrics\",
name=\"pinot.server.highestStreamOffsetConsumed.([^\\.]*?)_(OFFLINE|REALTIME)\\-(.+)\\-(\\w+)\"><>(\\w+)"
+# name: "pinot_server_highestStreamOffsetConsumed_$5"
+# cache: true
+# labels:
+# table: "$1"
+# tableType: "$2"
+# topic: "$3"
+# partition: "$4"
Review Comment:
and also can we remove other commented code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
