klsince opened a new pull request, #12232: URL: https://github.com/apache/pinot/pull/12232
This PR refines the way to take snapshot for validDocIds of upsert table: 1. make it more atomic when to take snapshot, by writing to a tmp file and then rename to snapshot file, instead of writing directly to snapshot file 2. take snapshots for segments with existing snapshots first, so that upon failure to take all snapshots, the snapshots left on disk still track an 'exclusive' set of valid docs among segments. The set of valid docs tracked by those snapshots might be incomplete due to failure, but that can be handled correctly when server loads the segments again. 3. misc: remove dead code found along the way; and allow to override preloadSegment() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
