walterddr commented on code in PR #12241:
URL: https://github.com/apache/pinot/pull/12241#discussion_r1445491801
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -562,6 +570,25 @@ private void handleUpsert(ImmutableSegment
immutableSegment) {
}
}
+ // Same as the SegmentLocks, but just for handleUpsert method to synchronize
threads doing segment replacement.
+ private static class UpsertSegmentLocks {
Review Comment:
We can make the class abstract and create 2 static instance one for generic
and one for upsert. (This way we can extend more later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
