gortiz commented on code in PR #12223:
URL: https://github.com/apache/pinot/pull/12223#discussion_r1450135130
##########
pinot-spi/src/test/java/org/apache/pinot/spi/config/table/IndexingConfigTest.java:
##########
@@ -46,6 +46,9 @@ public void testSerDe()
indexingConfig.setOnHeapDictionaryColumns(onHeapDictionaryColumns);
List<String> bloomFilterColumns = Arrays.asList("a", "b");
indexingConfig.setBloomFilterColumns(bloomFilterColumns);
+ Map<String, BloomFilterConfig> bloomFilterConfigs = new HashMap<>();
+ bloomFilterConfigs.put("a", new BloomFilterConfig(0.123, 456, true));
+ indexingConfig.setBloomFilterConfigs(bloomFilterConfigs);
Review Comment:
Is this a lateral change or is it actually related to the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
