walterddr commented on code in PR #12258:
URL: https://github.com/apache/pinot/pull/12258#discussion_r1451082198
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -562,6 +563,16 @@ public void setProcessingExceptions(List<String>
processingExceptions) {
_processingExceptions.addAll(processingExceptions);
}
+ @Override
+ public Map<String, List<String>> getRequestHttpHeaders() {
Review Comment:
this have some problem --> for example i highly doubt we should keep the
entire request header in (even for debugging purposes) . for example, we surely
dont want to keep the auth token in here
this prompts me to wonder if we should actually explicitly keep the part of
the header explicitly instead of having a generic map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
