tibrewalpratik17 commented on code in PR #12275:
URL: https://github.com/apache/pinot/pull/12275#discussion_r1456157807
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -950,6 +950,40 @@ public String getTableAggregateMetadata(
return segmentsMetadata;
}
+ @GET
+ @Path("tables/{tableName}/validDocIdMetadata")
+ @Authorize(targetType = TargetType.TABLE, paramName = "tableName", action =
Actions.Table.GET_METADATA)
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "Get the aggregate valid doc id metadata of all
segments for a table", notes = "Get the "
+ + "aggregate valid doc id metadata of all segments for a table")
+ public String getTableAggregateValidDocIdMetadata(
Review Comment:
Can we also add an optional list of segmentNames in the API request? This
will be ideal for tables with a lot of segments.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -950,6 +950,40 @@ public String getTableAggregateMetadata(
return segmentsMetadata;
}
+ @GET
+ @Path("tables/{tableName}/validDocIdMetadata")
+ @Authorize(targetType = TargetType.TABLE, paramName = "tableName", action =
Actions.Table.GET_METADATA)
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "Get the aggregate valid doc id metadata of all
segments for a table", notes = "Get the "
+ + "aggregate valid doc id metadata of all segments for a table")
+ public String getTableAggregateValidDocIdMetadata(
+ @ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr) {
Review Comment:
The table type should always be `REALTIME` as this API makes sense only for
upsert tables. Should we just remove this from request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
