Jackie-Jiang commented on code in PR #12218:
URL: https://github.com/apache/pinot/pull/12218#discussion_r1457921930
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/ForwardIndexConfig.java:
##########
@@ -99,6 +171,8 @@ public int hashCode() {
}
public static class Builder {
+ @Nullable
+ private CompressionCodec _compressionCodec;
Review Comment:
IMO we don't need to keep `Builder` backward compatible. We do want to keep
the config backward compatible. We may remove `dictIdCompressionType` from the
config since that is not released yet, but should keep `chunkCompressionType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
