jackjlli commented on PR #12042: URL: https://github.com/apache/pinot/pull/12042#issuecomment-1899555330
Hey @davecromberge @snleee @swaminathanmanish , thanks for making the contribution to theta sketch functionality! We really appreciate that! While this PR introduces the backward compatibility that the data type is switched from `Sketch` to `ThetaSketchAccumulator`, which caused the existing tables running with `distinctCountThetaSketch` or `distinctCountRawThetaSketch` functionalities fail during the deployment time because of two different OSS versions being present in brokers and servers at the same time. This PR should have been marked as `backward incompatible`. And this is blocking our deployment in LinkedIn. Could you please adjust the code to make sure this enhancement won't break the existing running tables? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
