klsince commented on code in PR #12250:
URL: https://github.com/apache/pinot/pull/12250#discussion_r1458348755
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -514,6 +521,24 @@ public void removeSegment(IndexSegment segment) {
return;
}
}
+
+ if (_helixManager != null) {
+ try {
+ HelixDataAccessor dataAccessor = _helixManager.getHelixDataAccessor();
+ PropertyKey propertyKey =
dataAccessor.keyBuilder().idealStates(_tableNameWithType);
+ IdealState idealState = dataAccessor.getProperty(propertyKey);
+ if (!idealState.isEnabled()) {
Review Comment:
For my learning, what’s the effect to disable a table? Because I’d wonder if
we could reuse some of the logic of dropping table on the server (as that logic
was improved to avoid cleaning up upsert states for each individual segment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
