Jackie-Jiang commented on code in PR #12290: URL: https://github.com/apache/pinot/pull/12290#discussion_r1460699587
########## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ########## @@ -87,6 +87,7 @@ public static DimensionTableDataManager getInstanceByTableName(String tableNameW private final AtomicInteger _loadToken = new AtomicInteger(); private boolean _disablePreload = false; + private boolean _allowDuplicatePrimaryKey = true; Review Comment: Using `true` as default boolean config might be error prone. Consider changing it to `errorOnDuplicatePrimaryKey` and default to `false`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
