walterddr commented on code in PR #12293:
URL: https://github.com/apache/pinot/pull/12293#discussion_r1468946326
##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -271,6 +271,7 @@ public enum TransformFunctionType {
OperandTypes.family(ImmutableList.of(SqlTypeFamily.ARRAY)),
"vector_norm"),
ARRAY_VALUE_CONSTRUCTOR("arrayValueConstructor", "array_value_constructor"),
+ ARRAY_GENERATE("arrayGenerate", "array_generate"),
Review Comment:
removing this entry will make your transform function implementation unable
to register (thus unable to run / dead code).
i would suggest wait until #12302 to be checked in b/c the type system
implication is complex for ARRAY_GEN
also another note to reviewer --> histogram does support a weird array gen.
let's see if we can merge the 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
