floren06 commented on code in PR #12337:
URL: https://github.com/apache/pinot/pull/12337#discussion_r1470147981
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##########
@@ -30,20 +35,29 @@
import org.apache.pinot.spi.config.table.TableConfig;
import org.apache.pinot.spi.data.Schema;
import org.apache.pinot.spi.utils.builder.TableNameBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class PurgeTaskExecutor extends BaseSingleSegmentConversionExecutor {
public static final String RECORD_PURGER_KEY = "recordPurger";
public static final String RECORD_MODIFIER_KEY = "recordModifier";
public static final String NUM_RECORDS_PURGED_KEY = "numRecordsPurged";
public static final String NUM_RECORDS_MODIFIED_KEY = "numRecordsModified";
+ private static final ThreadMXBean MX_BEAN =
ManagementFactory.getThreadMXBean();
+ private long _startTimeNs;
+ private long _endTimeNs;
+ private long _startAllocatedBytes;
+ private long _endAllocatedBytes;
+ private static final Logger LOGGER =
LoggerFactory.getLogger(PurgeTaskExecutor.class);
Review Comment:
Addressed comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]