snleee commented on code in PR #12346:
URL: https://github.com/apache/pinot/pull/12346#discussion_r1475063849
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java:
##########
@@ -160,6 +170,20 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
return pinotTaskConfigs;
}
+ private String getDefaultValidDocId(UpsertConfig upsertConfig) {
Review Comment:
updated
1. throw error if enableSnapshot is not set to true.
2. throw error if queryableDocId type is set while upsert delete column is
not enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
