swaminathanmanish commented on code in PR #12350:
URL: https://github.com/apache/pinot/pull/12350#discussion_r1475083432
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/util/SegmentDeletionManagerTest.java:
##########
@@ -357,6 +358,9 @@ public void createTableAndSegmentFiles(File tempDir,
List<String> segmentIds)
tableDir.mkdir();
for (String segmentId : segmentIds) {
createTestFileWithAge(tableDir.getAbsolutePath() + File.separator +
segmentId, 0);
+ // Create segment metadata file
+ createTestFileWithAge(
Review Comment:
yes added metadata file as well. At the end of the test, there's a
verification that the directory does not have any files -
```
try {
Assert.assertEquals(tableDir.listFiles().length, 0);
Assert.assertTrue(!deletedTableDir.exists() ||
deletedTableDir.listFiles().length == );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
