KKcorps commented on code in PR #12332:
URL: https://github.com/apache/pinot/pull/12332#discussion_r1477900874
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java:
##########
@@ -85,8 +85,9 @@ public JsonAsyncHttpPinotClientTransportFactory
withConnectionProperties(Propert
_headers = ConnectionUtils.getHeadersFromProperties(properties);
}
- if (_scheme == null) {
- _scheme = properties.getProperty("scheme",
CommonConstants.HTTP_PROTOCOL);
+ String scheme = properties.getProperty("scheme",
CommonConstants.HTTP_PROTOCOL);
+ if (_scheme == null || !_scheme.contentEquals(scheme)) {
+ _scheme = scheme;
}
Review Comment:
When someone is using Java Client in their code and do not use the builder
pattern, the scheme:https property never gets enforced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
