walterddr commented on code in PR #12370:
URL: https://github.com/apache/pinot/pull/12370#discussion_r1478961612
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java:
##########
@@ -92,8 +92,9 @@ public static OpChain
compileLeafStage(OpChainExecutionContext executionContext,
DistributedStagePlan distributedStagePlan, HelixManager helixManager,
ServerMetrics serverMetrics,
QueryExecutor leafQueryExecutor, ExecutorService executorService) {
long queryArrivalTimeMs = System.currentTimeMillis();
- ServerPlanRequestContext serverContext = new
ServerPlanRequestContext(distributedStagePlan, leafQueryExecutor,
- executorService, executionContext.getPipelineBreakerResult());
+ ServerPlanRequestContext serverContext =
Review Comment:
seems like all auto-formatting? (skipping most of these kinds)
##########
pinot-common/src/main/proto/mailbox.proto:
##########
@@ -17,24 +17,6 @@
// under the License.
//
-/**
Review Comment:
lol we should do license check better
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperatorTest.java:
##########
@@ -64,40 +69,35 @@ public class MailboxReceiveOperatorTest {
private ReceivingMailbox _mailbox1;
@Mock
private ReceivingMailbox _mailbox2;
- private StageMetadata _stageMetadataBoth;
- private StageMetadata _stageMetadata1;
- @BeforeMethod
+ @BeforeClass
Review Comment:
was this change related to Ser/De or just test optimization?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -204,6 +213,18 @@ void submit(long requestId, DispatchableSubPlan
dispatchableSubPlan, long timeou
}
}
+ private static class StageInfo {
Review Comment:
do we still need stage info . I saw it got added during #12358 then removed
in #12363 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
