xiangfu0 commented on code in PR #12401:
URL: https://github.com/apache/pinot/pull/12401#discussion_r1494328544
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -346,6 +372,19 @@ private HintStrategyTable getHintStrategyTable() {
return PinotHintStrategyTable.PINOT_HINT_STRATEGY_TABLE;
}
+ private static HepProgram getRewriteProgram() {
+ HepProgramBuilder hepProgramBuilder = new HepProgramBuilder();
+ // Set the match order as DEPTH_FIRST. The default is arbitrary which
works the same as DEPTH_FIRST, but it's
+ // best to be explicit.
+ hepProgramBuilder.addMatchOrder(HepMatchOrder.DEPTH_FIRST);
+
+ hepProgramBuilder.addRuleInstance(StringToByteCastRule.OnFilter.INSTANCE);
Review Comment:
Is there any missing Logical nodes? E.g. `LogicalSort`
```
LogicalAggregate
LogicalCalc
LogicalCorrelate
LogicalExchange
LogicalFilter
LogicalIntersect
LogicalJoin
LogicalMatch
LogicalMinus
LogicalProject
LogicalRepeatUnion
LogicalSnapshot
LogicalSort
LogicalSortExchange
LogicalTableFunctionScan
LogicalTableModify
LogicalTableScan
LogicalTableSpool
LogicalUnion
LogicalValues
LogicalWindow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
