gortiz opened a new pull request, #12447: URL: https://github.com/apache/pinot/pull/12447
This PR removes all usages of Lombok in Apache Pinot. After hours trying to find why I wasn't able to run tests in Intellij in a specific computer while in maven and other computers they ran without issues, I've decided to create a branch where lombok was disabled so I could continue working. I was finally able to find the problem in the specific computer (intellij was compiling with Scala for some reason and Scala and Lombok are not friends in intellij). But given how few lines of code we can skip with lombok and the problems it may add, I'm sharing here this PR where lombok is removed. I am completely biased, but I firmly think Lombok is a problematic project that should never be used. In our case, where it was simply used to remove some getter and setters, there is absolutly no reason to use it given we can generate these getters and setters easily. In the future, once we move source code to Java 21, we will be able to write 1 line pojos in the form of records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
