gortiz commented on PR #12403: URL: https://github.com/apache/pinot/pull/12403#issuecomment-1956486692
It seems this PR is not enough to remove all server metrics. Specifically, the following metrics survive: ``` name="pinot.server.endToEndRealtimeIngestionDelayMs.meetupRsvp_REALTIME.X",type="ServerMetrics" name="pinot.server.highestStreamOffsetConsumed.meetupRsvp_REALTIME-meetupRSVPEvents-X",type="ServerMetrics" name="pinot.server.lastRealtimeSegmentCompletionDurationSeconds.meetupRsvp_REALTIME-meetupRSVPEvents-X",type="ServerMetrics" name="pinot.server.lastRealtimeSegmentCreationDurationSeconds.meetupRsvp_REALTIME-meetupRSVPEvents-X",type="ServerMetrics" name="pinot.server.lastRealtimeSegmentInitialConsumptionDurationSeconds.meetupRsvp_REALTIME-meetupRSVPEvents-X",type="ServerMetrics" name="pinot.server.meetupRsvp.segmentUploadSuccess",type="ServerMetrics" name="pinot.server.meetupRsvp.segmentUploadTimeMs",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME-meetupRSVPEvents-X.realtimeRowsConsumed",type="ServerMetrics" name="pinot.server.realtimeOffheapMemoryUsed.meetupRsvp",type="ServerMetrics" ``` As you can see most of the metrics that survive were either indexed by table name (`meetupRsvp_REALTIME-meetupRSVPEvents-X` is the name of the kafka client where X is the partition) or the name without type (like `pinot.server.meetupRsvp.segmentUploadTimeMs`). `pinot.server.endToEndRealtimeIngestionDelayMs.meetupRsvp_REALTIME.X` should be deleted in `IngestionDelayTracker.removePartitionId`. I've added a commit to delete it. While the following were deleted: ``` name="pinot.server.meetupRsvp_REALTIME.buildQueryPlan",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.deletedSegmentCount",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.freshnessLagMs",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.nettyConnectionSendResponseLatency",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.numDocsScanned",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.numEntriesScannedPostFilter",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.numResizes",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.numSegmentsMatched",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.numSegmentsProcessed",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.numSegmentsQueried",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.queryPlanExecution",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.queryProcessing",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.requestDeserialization",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.responseSerialization",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.schedulerWait",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.segmentPruning",type="ServerMetrics" name="pinot.server.meetupRsvp_REALTIME.totalQueryTime",type="ServerMetrics" name="pinot.server.segmentCount.meetupRsvp_REALTIME",type="ServerMetrics" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
