jadami10 opened a new pull request, #12464: URL: https://github.com/apache/pinot/pull/12464
This is a `bugfix` to ensure someone does not incorrectly set up ingestion aggregation. Currently, `MutableSegmentImpl` will just disable aggregation if you do not have `noDictionaryColumns` for all `columnName` in `aggregationConfigs`. This caused an issue in one of our clusters because all of the aggregations showed up as `0`. This will not break existing tables as validation is only done when the table is created or updated. But even if anyone was using these configs incorrectly and runs into this error message, they can just delete the configs since they're doing nothing anyway. This was tested on an internal cluster where I verified: - you cannot remove existing aggregation columns from noDictionaryConfigs - you cannot add new aggregation columns without adding them to noDictionaryConfigs - you cannot make a new table without all aggregation columns in noDictionaryConfigs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
