gortiz commented on code in PR #12265:
URL: https://github.com/apache/pinot/pull/12265#discussion_r1498926674
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -288,7 +288,7 @@ private Map<String, FieldIndexConfigs>
calculateIndexConfigsByColName(@Nullable
return FieldIndexConfigsUtil.createIndexConfigsByColName(tableConfig,
schema, this::getDeserializer);
}
- private <C extends IndexConfig> ColumnConfigDeserializer<C>
getDeserializer(IndexType<C, ?, ?> indexType) {
+ public <C extends IndexConfig> ColumnConfigDeserializer<C>
getDeserializer(IndexType<C, ?, ?> indexType) {
Review Comment:
I don't think we need to make this public. See the comment in
AbstractSerderIndexContract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
