egalpin commented on code in PR #12414:
URL: https://github.com/apache/pinot/pull/12414#discussion_r1499585136
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -145,6 +149,33 @@ public static boolean isSkipScanFilterReorder(Map<String,
String> queryOptions)
return
"false".equalsIgnoreCase(queryOptions.get(QueryOptionKey.USE_SCAN_REORDER_OPTIMIZATION));
}
+ @Nullable
+ public static Map<String, Set<FieldConfig.IndexType>>
getIndexSkipConfig(Map<String, String> queryOptions) {
+ // Example config: indexSkipConfig='col1=inverted,range&col2=inverted'
+ String indexSkipConfigStr =
queryOptions.get(QueryOptionKey.INDEX_SKIP_CONFIG);
+ if (indexSkipConfigStr == null) {
+ return null;
+ }
+
+ String[] perColumnIndexSkip = indexSkipConfigStr.split("&");
+ Map<String, Set<FieldConfig.IndexType>> indexSkipConfig = new HashMap<>();
+ for (String columnConf : perColumnIndexSkip) {
+ String[] conf = columnConf.split("=");
+ if (conf.length != 2) {
+ continue;
Review Comment:
@gortiz would a `org.apache.pinot.sql.parsers.parser.ParseException` be a
good choice here? I don't know if that exception is reserved for SQL _not
including_ query options, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
