xiangfu0 commented on code in PR #12480:
URL: https://github.com/apache/pinot/pull/12480#discussion_r1500657705
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/Constants.java:
##########
@@ -34,7 +34,7 @@ private Constants() {
public static final String[] SCHEMA_COLUMNS_DTYPES = {"STRING", "STRING"};
public static final String[] TABLE_COLUMNS = {
- "TABLE_SCHEM", "TABLE_CATALOG", "TABLE_NAME", "TABLE_TYPE", "REMARKS",
"TYPE_CAT", "TYPE_SCHEM", "TYPE_NAME",
+ "TABLE_CAT", "TABLE_SCHEM", "TABLE_NAME", "TABLE_TYPE", "REMARKS",
"TYPE_CAT", "TYPE_SCHEM", "TYPE_NAME",
Review Comment:
Ah, saw this the PR description: `The last commit contains a fix of
TABLE_CATALOG column name - based on JDBC standard it must be TABLE_CAT and it
must be presented in the first place of each metadata table.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
