ankitsultana commented on PR #12479: URL: https://github.com/apache/pinot/pull/12479#issuecomment-1963500683
I am not sure how to test this via UTs. The user-agent config is passed to the Apache Commons HttpClient. After the client is created, there's no way to verify what the user-agent config value is. You can refer to `org.apache.http.impl.client.HttpClientBuilder#build`. The part where this config is used is in the screenshot in the description. Existing UTs take care of sanity testing the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
