jadami10 opened a new pull request, #12499: URL: https://github.com/apache/pinot/pull/12499
This is a bugfix related to #10891. That PR added support for setting min/max column metadata for no dictionary columns, but it didn't add support for all data types. This specifically affected us because we use no dictionary columns + ingestion aggregation. By returning rather than throwing an exception, we effectively revert to the previous behavior of not having the metadata. I've added unit tests with no data just to ensure this doesn't break. I've also tested on a broken cluster internally where segment commits were failing with the `IllegalStateException`. Segment commits were able to proceed with this fix. Ideally we would add support for all data types, but I want to unblock this cluster upgrade before undertaking a larger fix. The code isn't particularly complicated, but setting up more robust unit tests that test all data types will take me some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
