tibrewalpratik17 commented on code in PR #12498:
URL: https://github.com/apache/pinot/pull/12498#discussion_r1503795294
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java:
##########
@@ -108,6 +108,19 @@ public Instances getAllInstances() {
return new Instances(_pinotHelixResourceManager.getAllInstances());
}
+ @GET
+ @Path("/liveinstances")
+ @Authorize(targetType = TargetType.CLUSTER, action =
Actions.Cluster.GET_INSTANCE)
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "List all live instances")
Review Comment:
I tested via the following:
- Restarted a node in one of our clusters. During the restart we did not get
the instance id of that node in the `/liveinstances` ZK path. Post restart, we
got the instance back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
