xiangfu0 commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1511663907
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -150,10 +153,12 @@ public abstract class BaseBrokerRequestHandler implements
BrokerRequestHandler {
private final boolean _enableQueryLimitOverride;
private final boolean _enableDistinctCountBitmapOverride;
private final Map<Long, QueryServers> _queriesById;
+ private final ZkHelixPropertyStore<ZNRecord> _propertyStore;
public BaseBrokerRequestHandler(PinotConfiguration config, String brokerId,
BrokerRoutingManager routingManager,
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
- BrokerMetrics brokerMetrics, BrokerQueryEventListener
brokerQueryEventListener) {
+ BrokerMetrics brokerMetrics, BrokerQueryEventListener
brokerQueryEventListener,
Review Comment:
See if you can reuse TableCache for this, no need to set `propertyStore`
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
