Jackie-Jiang commented on code in PR #12568:
URL: https://github.com/apache/pinot/pull/12568#discussion_r1515672339
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##########
@@ -291,6 +297,88 @@ private RoaringBitmap getMatchingFlattenedDocIds(Predicate
predicate) {
} else {
return new RoaringBitmap();
}
+ } else if (predicateType == Predicate.Type.REGEXP_LIKE) {
+ String ceilingKey = _postingListMap.ceilingKey(key +
BaseJsonIndexCreator.KEY_VALUE_SEPARATOR);
Review Comment:
I was suggesting to handle it similar to the immutable one, where we lookup
the `key` from the map (`_postingListMap.get(key)`), if it returns `null` it
means the key does not exist; if it exists, we can use `key` as lower bound to
calculate the `subMap`, and set the lower bound to be exclusive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
