Jackie-Jiang commented on code in PR #12587:
URL: https://github.com/apache/pinot/pull/12587#discussion_r1515682488
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV4.java:
##########
@@ -94,7 +94,7 @@ public class VarByteChunkForwardIndexWriterV4 implements
VarByteChunkWriter {
public VarByteChunkForwardIndexWriterV4(File file, ChunkCompressionType
compressionType, int chunkSize)
throws IOException {
- _dataBuffer = new File(file.getName() + DATA_BUFFER_SUFFIX);
+ _dataBuffer = new File(file.getParentFile(), file.getName() +
DATA_BUFFER_SUFFIX);
Review Comment:
We might also want to check its existence, and delete it if exists
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/creator/VarByteChunkV4Test.java:
##########
@@ -46,73 +47,122 @@
public class VarByteChunkV4Test {
- private static final File TEST_DIR = new File(FileUtils.getTempDirectory(),
"VarByteChunkV4Test");
+ private static File[] _dirs;
- private File _file;
-
- @DataProvider
+ @DataProvider(parallel = true)
Review Comment:
I feel we can simplify the test by just checking whether the buffer file is
created at desired location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
