Jackie-Jiang commented on code in PR #12613:
URL: https://github.com/apache/pinot/pull/12613#discussion_r1520582092
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryTestSet.java:
##########
@@ -106,6 +106,9 @@ public Object[][] provideTestSql() {
+ " SUM(CASE WHEN a.col2 <> 'foo' AND a.col2 <> 'alice' THEN 1
ELSE 0 END) as unmatch_sum "
+ " FROM a WHERE a.ts >= 1600000000 GROUP BY a.col1"},
+ new Object[]{"SELECT a.col1, CASE WHEN sum(a.col3) = 0 THEN 0 ELSE
SUM(a.col3) END AS match_sum "
+ + " FROM a WHERE a.ts >= 1600000000 GROUP BY a.col1"},
Review Comment:
Actually we want to add tests for V1. It is already working in V2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
