jadami10 commented on PR #12632: URL: https://github.com/apache/pinot/pull/12632#issuecomment-1991957983
I don't think this is the right solution because it will cause the page to unnecessarily jump between the tables not being rendered then being rendered. @abhioncbr was the right first step in #12610, but it probably causes the tables to look momentarily weird since only the first column is rendered. I think it might also cause bugs in other parts of the UI since `cluster` can be undefined for other uses of this component - `HomePage.tsx` we request `Instances` and pass clusterName - `Instances` returns `AsyncInstanceTable` with `showInstanceDetails` and `cluster` which tells that component to show all instance details - but to get all instance details, it needs the cluster name from props to fetch `LIVEINSTANCES` - I think we effectively need 3 if statements -- if showInstanceDetails, and cluster is defined, and cluster is an empty string; show the instance names and the rest of the data as "Loading" -- if showinstanceDetails, and cluster is defined, and cluster is a non-empty string; get the liveInstanceDetails and set that as the data -- otherwise, the current `else` statement Let me know if this makes sense and you want to implement it. Otherwise I can send out a PR tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
