shounakmk219 commented on code in PR #12591:
URL: https://github.com/apache/pinot/pull/12591#discussion_r1527884982
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DatabaseUtils.java:
##########
@@ -84,4 +84,13 @@ public static String translateTableName(String tableName,
HttpHeaders headers, b
public static String translateTableName(String tableName, HttpHeaders
headers) {
return translateTableName(tableName, headers, false);
}
+
+ public static boolean isPartOfDatabase(String tableName, @Nullable String
databaseName) {
+ // assumes tableName will not have default database prefix ('default.')
+ if (StringUtils.isEmpty(databaseName) ||
databaseName.equalsIgnoreCase(CommonConstants.DEFAULT_DATABASE)) {
+ return StringUtils.split(tableName, '.').length == 1;
Review Comment:
Agree, thanks for catching! Will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
