This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1f668c72d2 Assign default value to newly added derived column upon
reload (#12648)
1f668c72d2 is described below
commit 1f668c72d29c264e723510d397f0aea518c27b34
Author: Shounak kulkarni <[email protected]>
AuthorDate: Tue Mar 19 02:52:02 2024 +0500
Assign default value to newly added derived column upon reload (#12648)
---
.../index/loader/defaultcolumn/BaseDefaultColumnHandler.java | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
index bb55d27f33..67e92fd63a 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
@@ -368,14 +368,10 @@ public abstract class BaseDefaultColumnHandler implements
DefaultColumnHandler {
for (String argument : arguments) {
ColumnMetadata columnMetadata =
_segmentMetadata.getColumnMetadataFor(argument);
if (columnMetadata == null) {
- LOGGER.warn("Skip creating derived column: {} because argument:
{} does not exist in the segment", column,
- argument);
- if (errorOnFailure) {
- throw new RuntimeException(String.format(
- "Failed to create derived column: %s because argument: %s
does not exist in the segment", column,
- argument));
- }
- return false;
+ LOGGER.warn("Assigning default value to derived column: {}
because argument: {} does not exist in the "
+ + "segment", column, argument);
+ createDefaultValueColumnV1Indices(column);
+ return true;
}
// TODO: Support creation of derived columns from forward index
disabled columns
if (!_segmentWriter.hasIndexFor(argument,
StandardIndexes.forward())) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
