soumitra-st commented on code in PR #12722: URL: https://github.com/apache/pinot/pull/12722#discussion_r1538295227
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ########## @@ -199,14 +199,19 @@ public void preloadSegments(IndexLoadingConfig indexLoadingConfig) { return; } // From now on, the _isPreloading flag is true until the segments are preloaded. + long startTime = System.currentTimeMillis(); Review Comment: We should use System.nanoTime to measure duration, since System.currentTimeMillis is not guaranteed to be monotonically increasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org