davecromberge commented on PR #12778: URL: https://github.com/apache/pinot/pull/12778#issuecomment-2033021774
> Do you also need to set threshold? Good catch - you are correct. This has now been included. > The root cause of this is that the intermediate result is not fully serialized If by this you mean that it is falling back on the sketch serialiser - yes. The reason for this is described above. I found a use case in the tests where the results from servers are inspected directly / programmatically and I'm unsure whether this represents a real world use case. If we can discard this use case we can then consider how best to provide a backward compatible serialiser for the current (Theta) implementation. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
