lnbest0707-uber commented on issue #12732: URL: https://github.com/apache/pinot/issues/12732#issuecomment-2035930362
> Do you run into this problem after updating server config via controller API, or directly modify Zookeeper? Seems like the ZNode becomes an invalid JSON, thus causing the problem. It is very hard to make the cluster handle invalid ZNode. E.g. if you have one ideal state that is invalid JSON, the whole Helix framework will stuck. > > If the modification is through regular controller API, then we should add a check to ensure it is valid JSON. Thanks for the reply. I think the issue for this case is not **invalid Json** but ** NumberFormatException** where port number is a String unable to be converted to int. For such bad configuration host, we could ignore it but cannot accept it bringing down the entire cluster. One fix I can initiate is to try catch the error when broker building the instance selector map. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
