siddharthteotia commented on PR #12731: URL: https://github.com/apache/pinot/pull/12731#issuecomment-2036288986
I am not sure if this is the right thing to do or should be the default behavior. I guess if the pruner fails, there could be some silly bug in pruner itself or the metadata / data used to prune could be malformed (e.g negative partition IDs). So imo the query should fail. Also simply logging the exception and letting the query run without pruning does not help the oncall / admin / dev in fixing the root cause. For example, query on partitioned table can suddenly degrade in performance and someone will have to sift through logs to find the real reason. There should be some of metric if we really want this behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
