This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 70cfaca721 Bugfix. Correct wrong method call from scheduleTask() to
scheduleTaskForDatabase() (#12791)
70cfaca721 is described below
commit 70cfaca721aa9026a7215dd69ca5e8fe3f8b4b65
Author: Shounak kulkarni <[email protected]>
AuthorDate: Thu Apr 4 21:14:38 2024 +0500
Bugfix. Correct wrong method call from scheduleTask() to
scheduleTaskForDatabase() (#12791)
* Bugfix. Fix the wrong method call
* reassign accidentally removed deprecated annotation
---
.../apache/pinot/controller/api/resources/PinotTaskRestletResource.java | 2 +-
.../org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java
index e043d8377c..c51c266587 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java
@@ -624,7 +624,7 @@ public class PinotTaskRestletResource {
// Schedule task for the given task type
List<String> taskNames = tableName != null
? _pinotTaskManager.scheduleTask(taskType,
DatabaseUtils.translateTableName(tableName, headers))
- : _pinotTaskManager.scheduleTask(taskType, database);
+ : _pinotTaskManager.scheduleTaskForDatabase(taskType, database);
return Collections.singletonMap(taskType, taskNames == null ? null :
StringUtils.join(taskNames, ','));
} else {
// Schedule tasks for all task types
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
index 7150910b8b..9b2fced8c2 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
@@ -484,6 +484,7 @@ public class PinotTaskManager extends
ControllerPeriodicTask<Void> {
* It might be called from the non-leader controller.
* Returns a map from the task type to the list of tasks scheduled.
*/
+ @Deprecated
public synchronized Map<String, List<String>> scheduleTasks() {
return
scheduleTasks(_pinotHelixResourceManager.getAllTables(CommonConstants.DEFAULT_DATABASE),
false);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
