abhioncbr commented on code in PR #12440:
URL: https://github.com/apache/pinot/pull/12440#discussion_r1552619464
##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java:
##########
@@ -54,7 +59,8 @@ private CommonsConfigurationUtils() {
*/
public static PropertiesConfiguration fromFile(File file)
throws ConfigurationException {
- return fromFile(file, false, true);
+ return fromFile(file, false, true,
+ PropertyIOFactoryKind.DefaultPropertyConfigurationIOFactory);
Review Comment:
imo, The default IOFactory should be the
`PropertiesConfiguration.DefaultIOFactory()`, which is provided by
commons-configuration2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
