Jackie-Jiang commented on code in PR #11983:
URL: https://github.com/apache/pinot/pull/11983#discussion_r1552669242
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java:
##########
@@ -61,11 +62,12 @@ public void init(TableConfig tableConfig, Schema schema,
TableDataManager tableD
PartialUpsertHandler partialUpsertHandler = null;
if (upsertConfig.getMode() == UpsertConfig.Mode.PARTIAL) {
Map<String, UpsertConfig.Strategy> partialUpsertStrategies =
upsertConfig.getPartialUpsertStrategies();
- Preconditions.checkArgument(partialUpsertStrategies != null,
+ String rowMergerCustomImplementation =
upsertConfig.getPartialUpsertMergerClass();
+ Preconditions.checkArgument(
+ StringUtils.isNotBlank(rowMergerCustomImplementation) ||
partialUpsertStrategies != null,
Review Comment:
I've applied a commit to demonstrate the idea. The exception will be thrown
from the constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
