Jackie-Jiang commented on code in PR #12789:
URL: https://github.com/apache/pinot/pull/12789#discussion_r1552679449
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFieldSpec.java:
##########
@@ -74,6 +75,10 @@ public DateTimeFieldSpec(String name, DataType dataType,
String format, String g
@Nullable Object sampleValue) {
super(name, dataType, true);
+ // Override format to be "TIMESTAMP" for TIMESTAMP data type because the
format is implicit
+ if (dataType == DataType.TIMESTAMP) {
Review Comment:
This won't change existing schema. New uploaded/modified schema will be
changed.
This reminds me that I do need to change the JSON setter so that
create/update can be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
