mayankshriv commented on code in PR #12795:
URL: https://github.com/apache/pinot/pull/12795#discussion_r1552724252
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -243,7 +243,7 @@ public static String rtrim(String input) {
* @param input
* @return get substring starting from the first index and extending upto
specified length.
*/
- @ScalarFunction
+ @ScalarFunction(names = {"leftSubStr", "left"})
Review Comment:
I had checked, with v1, all variations are supported `left_substr`,
`leftSubStr`, `left_sub_str`, which is why I didn't add them explicitly. For
v2, we want to be Postgres compliant, so there is just `left`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
