abhioncbr commented on code in PR #12866:
URL: https://github.com/apache/pinot/pull/12866#discussion_r1559767788


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/vector/lucene95/HnswVectorsFormat.java:
##########
@@ -19,10 +19,10 @@
 package org.apache.pinot.segment.local.segment.creator.impl.vector.lucene95;
 
 import java.io.IOException;
+import org.apache.lucene.backward_codecs.lucene95.Lucene95HnswVectorsFormat;

Review Comment:
   @xiangfu0 / @Jackie-Jiang, this codec can not be used to write data since 
now it's in `backward_codec` package. unit test 
`LoaderTest.testVectorIndexLoad:766->constructSegmentWithVectorIndex:928` is 
failing with the following exception
   ```bash
   Caused by: java.lang.UnsupportedOperationException: Old codecs may only be 
used for reading
        at 
org.apache.lucene.backward_codecs.lucene95.Lucene95HnswVectorsFormat.fieldsWriter(Lucene95HnswVectorsFormat.java:182)
   ```
   based on the 
[conversation](https://lists.apache.org/thread/fl9ds5ofxgmq2obzh0j5hgsmp4n6jx65),
 I found, is it okay if I use lucene99 based codecs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to