gortiz opened a new pull request, #12955:
URL: https://github.com/apache/pinot/pull/12955
This PR changes several files, but the change is very simple. We had the
concept of _mailboxId_ but it was represented as a string. This PR adds a class
for that concept and change the usage in all the places it was used.
The only place where _mailboxId_ is being used as a string is GRPC message
`MailboxContent`. We need to do that to keep GPRC protocol simple and backward
compatible.
I think this will make the code easier to read but also improve error
messages. For example, in case of timeout, before this PR the message show was:
```
Received error query execution result block: {1000=Timed out while offering
data to mailbox: 1036791369000154169|2|4|1|4
```
And now it will be
```
Received error query execution result block: {1000=Timed out while offering
data to mailbox: {"requestId": 1036791369000154169, "senderStageId": 2,
"senderWorkerId": 4, "receiverStageId": 1, "receiverWorkerId": 4}
```
This message is still far from being great, but at least it doesn't look
like magic numbers like the ones used in the TV show _Lost_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
