Jackie-Jiang commented on code in PR #12958:
URL: https://github.com/apache/pinot/pull/12958#discussion_r1569358090
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/PinotReflectionUtils.java:
##########
@@ -53,7 +53,7 @@ public static Set<Class<?>>
getClassesThroughReflection(String packageName, Stri
try {
synchronized (REFLECTION_LOCK) {
return new Reflections(new
ConfigurationBuilder().setUrls(ClasspathHelper.forPackage(packageName))
- .filterInputsBy(new
FilterBuilder().includePattern(regexPattern))).getTypesAnnotatedWith(annotation);
+ .filterInputsBy(new
FilterBuilder.Include(regexPattern))).getTypesAnnotatedWith(annotation);
Review Comment:
I think it will work for both versions if you change this to
```suggestion
.filterInputsBy(new
FilterBuilder().include(regexPattern))).getTypesAnnotatedWith(annotation);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
