soumitra-st commented on PR #12957:
URL: https://github.com/apache/pinot/pull/12957#issuecomment-2062557491
> I don't think this is the correct fix. We rely on the callback to track
the ingestion delay. I feel the real issue is this metric is not removed after
the consumer is destroyed.
There are two issues:
1. Why metric is not removed when consumer is destroyed?
2. Why metric keep increasing when no consumer exists?
This PR address #2. In fact, the happy path publishes the metric after
every batch at
https://github.com/apache/pinot/blob/7f87cd3a9ffd7f73c14502d9457a037926aab75f/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java#L647
.
IMO, we need to fix both the issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
