jasperjiaguo commented on code in PR #12712:
URL: https://github.com/apache/pinot/pull/12712#discussion_r1571549507
##########
pinot-spi/pom.xml:
##########
@@ -179,39 +179,4 @@
<artifactId>reflections</artifactId>
</dependency>
</dependencies>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>false</activeByDefault>
- </activation>
Review Comment:
After removing this these module level profile the mvn build stopped to
publish shaded jars for spi which is required by our build pipeline. We should
probably add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
